From eb649d8204c9a4cf60b05c4941b05f0cad241af8 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Mon, 6 Apr 2020 19:16:41 -0400 Subject: [PATCH] shortcuttrigger: Don't trigger on key releases This broke when the event type check in gdk_key_event_matches was removed and replaced by a precondition that accepts both key press and release events. Add the check in gtk_keyval_trigger_trigger instead. --- gtk/gtkshortcuttrigger.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gtk/gtkshortcuttrigger.c b/gtk/gtkshortcuttrigger.c index 30ab0411ca..e6c8c016f8 100644 --- a/gtk/gtkshortcuttrigger.c +++ b/gtk/gtkshortcuttrigger.c @@ -516,6 +516,9 @@ gtk_keyval_trigger_trigger (GtkShortcutTrigger *trigger, { GtkKeyvalTrigger *self = GTK_KEYVAL_TRIGGER (trigger); + if (gdk_event_get_event_type (event) != GDK_KEY_PRESS) + return GDK_KEY_MATCH_NONE; + return gdk_key_event_matches (event, self->keyval, self->modifiers); } -- 2.30.2